feedback

scionproto · Sep 16, 2024 · fb13dfb · fb13dfb
1 parent 4a010c1
commit fb13dfb
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/doc/command/scion-pki/scion-pki_trc.rst b/doc/command/scion-pki/scion-pki_trc.rst
@@ -27,7 +27,7 @@ SEE ALSO
 * :ref:`scion-pki trc combine <scion-pki_trc_combine>` 	 - Combine partially signed TRCs
 * :ref:`scion-pki trc extract <scion-pki_trc_extract>` 	 - Extract parts of a signed TRC
 * :ref:`scion-pki trc format <scion-pki_trc_format>` 	 - Reformat a TRC or TRC payload
-* :ref:`scion-pki trc inspect <scion-pki_trc_inspect>` 	 - Represent TRC in a human readable form
+* :ref:`scion-pki trc inspect <scion-pki_trc_inspect>` 	 - Print TRC details in a human readable format
 * :ref:`scion-pki trc payload <scion-pki_trc_payload>` 	 - Generate new TRC payload
 * :ref:`scion-pki trc sign <scion-pki_trc_sign>` 	 - Sign a TRC
 * :ref:`scion-pki trc verify <scion-pki_trc_verify>` 	 - Verify a TRC chain

diff --git a/doc/command/scion-pki/scion-pki_trc_inspect.rst b/doc/command/scion-pki/scion-pki_trc_inspect.rst
@@ -5,13 +5,13 @@
 scion-pki trc inspect
 ---------------------
 
-Represent TRC in a human readable form
+Print TRC details in a human readable format
 
 Synopsis
 ~~~~~~~~
 
 
-'inspect' outputs the TRC contents in a inspect readable form.
+'inspect' prints the details of a TRC a human-readable fromat.
 
 The input file can either be a TRC payload, or a signed TRC.
 The output can either be in yaml, or json.

diff --git a/scion-pki/conf/trc.go b/scion-pki/conf/trc.go
@@ -52,7 +52,7 @@ func LoadTRC(file string) (TRC, error) {
 		return TRC{}, serrors.Wrap("unable to load TRC config from file", err, "file", file)
 	}
 	if err := cfg.Validity.Validate(); err != nil {
-		return TRC{}, serrors.Wrap("validating validity", err)
+		return TRC{}, serrors.Wrap("validating 'validity' section", err)
 	}
 	cfg.relPath = filepath.Dir(file)
 	return cfg, nil

diff --git a/scion-pki/trcs/BUILD.bazel b/scion-pki/trcs/BUILD.bazel
@@ -7,7 +7,7 @@ go_library(
         "decode.go",
         "extract.go",
         "format.go",
-        "human.go",
+        "inspect.go",
         "payload.go",
         "sign.go",
         "toasn.go",
@@ -40,7 +40,7 @@ go_test(
         "decoded_test.go",
         "export_test.go",
         "format_test.go",
-        "human_test.go",
+        "inspect_test.go",
         "sign_test.go",
         "toasn_test.go",
         "verify_test.go",

diff --git a/scion-pki/trcs/human.go → scion-pki/trcs/inspect.go b/scion-pki/trcs/human.go → scion-pki/trcs/inspect.go
@@ -51,10 +51,10 @@ func newHuman(pather command.Pather) *cobra.Command {
 	cmd := &cobra.Command{
 		Use:     "inspect",
 		Aliases: []string{"human"},
-		Short:   "Represent TRC in a human readable form",
+		Short:   "Print TRC details in a human readable format",
 		Example: fmt.Sprintf(`  %[1]s inspect ISD1-B1-S1.pld.der
   %[1]s inspect ISD1-B1-S1.trc`, pather.CommandPath()),
-		Long: `'inspect' outputs the TRC contents in a inspect readable form.
+		Long: `'inspect' prints the details of a TRC a human-readable fromat.
 
 The input file can either be a TRC payload, or a signed TRC.
 The output can either be in yaml, or json.

diff --git a/scion-pki/trcs/human_test.go → scion-pki/trcs/inspect_test.go b/scion-pki/trcs/human_test.go → scion-pki/trcs/inspect_test.go