revert changes from #4605

scionproto · Sep 16, 2024 · 94a91ab · 94a91ab
1 parent 0325fae
commit 94a91ab
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml
@@ -117,7 +117,7 @@ steps:
         - ./scion.sh run
         - tools/await-connectivity
         - ./bin/scion_integration || ( echo "^^^ +++" && false )
-        - ./bin/end2end_integration --attempts=3 || ( echo "^^^ +++" && false )
+        - ./bin/end2end_integration || ( echo "^^^ +++" && false )
       plugins: &scion-run-hooks
         - scionproto/metahook#v0.3.0:
             pre-command: .buildkite/cleanup-leftovers.sh
@@ -144,7 +144,7 @@ steps:
         - ./scion.sh topology -c topology/default-no-peers.topo
         - ./scion.sh run
         - tools/await-connectivity
-        - ./bin/end2end_integration --attempts=3 || ( echo "^^^ +++" && false )
+        - ./bin/end2end_integration || ( echo "^^^ +++" && false )
         - ./tools/integration/revocation_test.sh
       plugins: *scion-run-hooks
       artifact_paths: *scion-run-artifact-paths
@@ -161,7 +161,7 @@ steps:
         - ./scion.sh run
         - tools/await-connectivity
         - echo "--- run tests"
-        - ./bin/end2end_integration -d --attempts=3 || ( echo "^^^ +++" && false )
+        - ./bin/end2end_integration -d || ( echo "^^^ +++" && false )
       plugins: *scion-run-hooks
       artifact_paths: *scion-run-artifact-paths
       timeout_in_minutes: 15

diff --git a/tools/await-connectivity b/tools/await-connectivity
@@ -88,19 +88,16 @@ main() {
   local noncores=$(sed -n '/Non-core/,${s/^- //p}' gen/as_list.yml)
 
   for i in $(seq 1 "$QUIET"); do
-    check_connectivity "$cores" "$noncores" > /dev/null && return 0
+    check_connectivity "$cores" "$noncores" > /dev/null && exit 0
     sleep 1
   done
   for i in $(seq "$QUIET" $((TIMEOUT-1))); do
     echo "Check after ${i}s"
-    check_connectivity "$cores" "$noncores" && return 0
+    check_connectivity "$cores" "$noncores" && exit 0
     sleep 1
   done
   echo "Check after ${TIMEOUT}s"
   check_connectivity "$cores" "$noncores" || { echo "Timeout, giving up"; exit 1; }
 }
 
 main "$@"
-
-# that is not enough. Down segment registrations don't seem to happen fast.
-sleep 10