build: allow go test ./... to run without errors

Ensure `go test ./...` runs without errors out-of-the-box.
To this end, we guard the acceptance tests behind a skip tag because
they require a special setup and are not meant to be run as regular
unit tests. We also add stub packages for the linter tests.

acceptance/topo_cs_reload/reload_test.go

@@ -22,6 +22,7 @@ import (
 	"net/http"
 	"os"
 	"os/exec"
+	"strings"
 	"testing"
 	"time"
 
@@ -42,6 +43,10 @@ var (
 )
 
 func TestPSTopoReload(t *testing.T) {
+	if !strings.HasSuffix(os.Getenv("TEST_TARGET"), "go_default_test") {
+		t.Skip("This test only runs as bazel unit test")
+	}
+
 	// BUG(matzf): teardown is not called when setup fails. Rewrite with T.Cleanup and T.Tempdir
 	s := setupTest(t)
 	defer s.teardownTest(t)

acceptance/topo_daemon_reload/reload_test.go

@@ -21,6 +21,7 @@ import (
 	"net/http"
 	"os"
 	"os/exec"
+	"strings"
 	"testing"
 	"time"
 
@@ -31,6 +32,10 @@ import (
 )
 
 func TestSDTopoReload(t *testing.T) {
+	if !strings.HasSuffix(os.Getenv("TEST_TARGET"), "go_default_test") {
+		t.Skip("This test only runs as bazel unit test")
+	}
+
 	defer teardownTest(t)
 	setupTest(t)
 

tools/lint/logctxcheck/testdata/src/fake/lib/slog/slog.go

@@ -0,0 +1,20 @@
+// Copyright 2023 Anapaya Systems
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Package slog is a stub for testing
+package slog
+
+func Debug(string, ...any) {}
+func Info(string, ...any)  {}
+func Error(string, ...any) {}

tools/lint/logctxcheck/testdata/src/github.com/scionproto/scion/pkg/log/log.go

@@ -0,0 +1,32 @@
+// Copyright 2023 Anapaya Systems
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Package log is a stub for the actual log package. It allows the logctxcheck
+// analyzer tests to run.
+package log
+
+import "context"
+
+func Debug(string, ...any)           {}
+func Info(string, ...any)            {}
+func Error(string, ...any)           {}
+func New(...any) Logger              { return nil }
+func FromCtx(context.Context) Logger { return nil }
+func Root() Logger                   { return nil }
+
+type Logger interface {
+	Debug(string, ...any)
+	Info(string, ...any)
+	Error(string, ...any)
+}

tools/lint/serrorscheck/testdata/src/fake/serrors/serrors.go

@@ -0,0 +1,19 @@
+// Copyright 2023 Anapaya Systems
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Package serrors is a stub for testing
+package serrors
+
+func New(string, ...any) error        { return nil }
+func Wrap(error, error, ...any) error { return nil }

tools/lint/serrorscheck/testdata/src/github.com/scionproto/scion/pkg/private/serrors/serrors.go

@@ -0,0 +1,22 @@
+// Copyright 2023 Anapaya Systems
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Package serrors is a stub for the actual serrors package. It allows the
+// serrorscheck analyzer tests to run.
+package serrors
+
+func New(string, ...any) error            { return nil }
+func Wrap(error, error, ...any) error     { return nil }
+func WrapStr(error, string, ...any) error { return nil }
+func WithCtx(error, ...any) error         { return nil }