-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: to/from PyTorch JaggedTensor #3246
base: main
Are you sure you want to change the base?
feat: to/from PyTorch JaggedTensor #3246
Conversation
…tensor-functions' into maxymnaumchyk/add-to-from-jaggedtensor-functions # Conflicts: # src/awkward/operations/ak_to_jaggedtensor.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
@jpivarski should I also leave out a "keep_regular" parameter since it does the same as ak.from_regular()? It's kind of the same situation we talked about today (about "padded" parameter). |
You're right: it is. The situation is that we should be providing an interface to the user that's like Lego bricks that they can put together however they like. If there's an alternative way of doing something, it shouldn't be a feature of the new functions, because then we'd have to explain why someone would use one or the other. I agree that the |
thanks for such a detailed answer! |
No description provided.