Remove unnecessary check, return type will make sure it's Response

scheb · Mar 7, 2018 · ddce1d6 · ddce1d6
1 parent 2d8b595
commit ddce1d6
Showing 1 changed file with 0 additions and 6 deletions.
diff --git a/Security/Http/Firewall/TwoFactorListener.php b/Security/Http/Firewall/TwoFactorListener.php
@@ -181,9 +181,6 @@ private function onFailure(Request $request, AuthenticationException $failed): R
         $this->dispatchLoginEvent(TwoFactorAuthenticationEvents::FAILURE, $request, $this->tokenStorage->getToken());
 
         $response = $this->failureHandler->onAuthenticationFailure($request, $failed);
-        if (!($response instanceof Response)) {
-            throw new \RuntimeException('Authentication failure handler did not return a Response.');
-        }
 
         return $response;
     }
@@ -208,9 +205,6 @@ private function onSuccess(Request $request, TokenInterface $token): Response
         }
 
         $response = $this->successHandler->onAuthenticationSuccess($request, $token);
-        if (!($response instanceof Response)) {
-            throw new \RuntimeException('Authentication success handler did not return a Response.');
-        }
 
         return $response;
     }