-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error reports info to metals doctor #5683
Merged
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9f96d34
improvement: add error reports to doctor
kasiaMarek 1e78ec7
add summary information to error reports
kasiaMarek 5f05763
add possibility to czip reports from doctor
kasiaMarek 3a2b778
review changes
kasiaMarek b778bc7
include the build target in the report name
kasiaMarek 4985ffd
change constructors
kasiaMarek 60766ac
change build target par format + add test
kasiaMarek ceaabc5
review fixes
kasiaMarek 4745469
refactor `Doctor.getErrorReportSummary`
kasiaMarek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,6 +29,7 @@ final case class DoctorFolderResults( | |
messages: Option[List[DoctorMessage]], | ||
targets: Option[Seq[DoctorTargetInfo]], | ||
explanations: List[Obj], | ||
errorReports: List[ErrorReportInfo], | ||
) { | ||
def toJson: Obj = { | ||
val json = ujson.Obj( | ||
ckipp01 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
@@ -152,3 +153,19 @@ final case class DoctorFolderHeader( | |
base | ||
} | ||
} | ||
|
||
/** | ||
* Information about an error report. | ||
* @param name display name of the error | ||
* @param timestamp date and time timestamp of the report | ||
* @param uri error report file uri | ||
* @param buildTarget optional build target that error is associated with | ||
* @param shortSummary short error summary | ||
ckipp01 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
*/ | ||
final case class ErrorReportInfo( | ||
name: String, | ||
timestamp: Long, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm sending a timestamp but I wonder if it'd be better to send nicely formatted time-date string instead. |
||
uri: String, | ||
buildTarget: Option[String], | ||
shortSummary: String, | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to instead use the target name in the filename? Similar to how we do it with timestamp?