bugfix: handle EOF in java completions

scalameta · Sep 20, 2023 · f5aa2eb · f5aa2eb
1 parent f8ddd02
commit f5aa2eb
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/mtags-java/src/main/scala/scala/meta/internal/pc/JavaCompletionProvider.scala b/mtags-java/src/main/scala/scala/meta/internal/pc/JavaCompletionProvider.scala
@@ -36,7 +36,9 @@ class JavaCompletionProvider(
   lazy val identifier = extractIdentifier.toLowerCase
   def completions(): CompletionList = {
     val nextIsWhitespace =
-      params.text().charAt(params.offset()).isWhitespace
+      if (params.offset() < params.text().length())
+        params.text().charAt(params.offset()).isWhitespace
+      else false
     val textWithSemicolon =
       if (nextIsWhitespace)
         params.text().substring(0, params.offset()) +

diff --git a/mtags/src/main/scala/scala/meta/internal/mtags/JavaToplevelMtags.scala b/mtags/src/main/scala/scala/meta/internal/mtags/JavaToplevelMtags.scala
@@ -80,7 +80,7 @@ class JavaToplevelMtags(val input: Input.VirtualFile) extends MtagsIndexer {
     @tailrec
     def kwOrIdent(start: Int, builder: StringBuilder): Token = {
       val ch = reader.ch
-      if (Character.isJavaIdentifierPart(ch)) {
+      if (ch != SU && Character.isJavaIdentifierPart(ch)) {
         reader.nextChar()
         kwOrIdent(start, builder.append(ch))
       } else if (builder.isEmpty) {

diff --git a/tests/javapc/src/test/scala/pc/CompletionKeywordSuite.scala b/tests/javapc/src/test/scala/pc/CompletionKeywordSuite.scala
@@ -53,6 +53,15 @@ class CompletionKeywordSuite extends BaseJavaCompletionSuite {
       |""".stripMargin,
   )
 
+  check(
+    "end of file",
+    """
+      |pac@@""".stripMargin,
+    """
+      |package
+      |""".stripMargin,
+  )
+
   check(
     "extends",
     """