[WIP] Load monaco using the webpack plugin #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas
force-pushed
the
monaco-editor-webpack-plugin
branch
from
ae09f02
to
3bfdaa8
Compare
|
#105 has now been merged so this needs a rebase. What would be the implications of loading monaco with the webpack plugin? |
jonas
force-pushed
the
monaco-editor-webpack-plugin
branch
from
3bfdaa8
to
154ea6d
Compare
|
The plugin allows to only include the parts of the editor that is needed for this project, so ideally it will reduce the size. This is currently blocked by microsoft/monaco-editor-webpack-plugin#26 which was fixed in 1.5.0 and requires Monaco Editor version 1.4.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resulting code is not currently minified so the generated site is much larger. That should be fixed with the Webpack 4 upgrade in #105 .