separate all messages during reload #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrf
reviewed
Jul 3, 2023
| @@ -52,7 +41,8 @@ class OutputExtractor(getScalaJsContent: () => Option[String], | |||
| && instrumentations.toList.flatten.isEmpty | |||
| && runtimeError.isEmpty | |||
| && !isDone | |||
| && !isSbtMessage | |||
| && !isHiddenSbtMessage | |||
| && !isReloading | |||
There was a problem hiding this comment.
Does that mean that we never show the user output when the sbt instance is reloading? Is that not an issue?
There was a problem hiding this comment.
Scastie output is displayed in the following way:
It starts with the SbtOutput and prints them until the first UserOutput is found. Afterwards it cleans the console and displays only the UserOutput. So changing this line effectively makes all output messages from reloading to be shown until the first UserOutput is printed.
There was a problem hiding this comment.
Ideally, we should add a button or a way to check build output in the UI, but this is not the scope of this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #865