Smart waiver

[sclark]

Prevent users from cheating or skipping the safety video

[coveralls]

Coverage increased (+0.06%) to 15.407% when pulling b44e8b8 on smart-waiver into a5b7e67 on new-features.

[pkoenig10]

FYI, better to rebase on top of your develop branch rather than merging. That way the commit history doesn't get cluttered with merge commits from feature branches. This is something that can easily lead to regressions.

[pkoenig10]

This is a bit of a hack. I'm fine with this fix for now because you need to get something that works for build week. But we should track this issue so we can implement a proper fix in the future.

[pkoenig10]

Change the error message to indicate why the user is seeing this page (skipping the waiver video). And the cute error message isn't really necessary, its better for users to use something clear and straightforward.

[sclark]

Will do

[sclark]

I like the merge commits, but seems like we rebase in this repo, so I will also rebase in the future

[sclark]

This may be hacky and should probably be made configurable, but almost anything on the client side can be manipulated, so this was the quickest, most sane way of doing things. Will keep issue #249 open for future consideration.

[coveralls]

Coverage increased (+0.06%) to 15.407% when pulling 9a34d15 on smart-waiver into a5b7e67 on new-features.

[sclark]

@pkoenig10 when pulling in updates from another branch, I understand the rebase and merge idea. When merging pull requests, is there a tradition of rebasing and merging in this repository?

[sclark]

If not, I prefer to make a merge commit so we can see that the code came from a different feature branch, but if there is a tradition, I wouldn't want to change it.

[timparenti]

"Safety" is misspelled on both lines.

[sclark]

I'm getting sloppy...Fixing this now.

[coveralls]

Coverage increased (+0.06%) to 15.407% when pulling 0cc0c1d on smart-waiver into a5b7e67 on new-features.