Fall Cleanup #52
Closed
Fall Cleanup #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # db/postgres/mod.go # go.mod # go.sum
chore: fix linter errors
# Conflicts: # api.go # go.mod
wtf how could this happen
# Conflicts: # schemas/tags.graphql
fix: reindex latest mods
Rewrite the compound conditional to avoid future confusions. This bug has gone unnoticed for so long because Alpakit-generated zip files do not contain folder entries when iterating with a `zipReader`. However, manually generated zip files, e.g. ContentLib mods, could contain folder entries depending on the zipping program used. The resulting zero-length folder in the per-target zips breaks SMM2 on Windows, but not SMM3.
* fix: urlencode filename for separate mod targets When a mod's name contains characters that should be urlencoded, any newly-uploaded versions cannot be download because of some errors regarding the URL being invalid. Make sure the returned key is urlencoded for consistency with the rest of the codebase. Signed-off-by: Angel Pons <[email protected]> * fix: urlencode version in `RenameFilename` As per Mircea's comment on [#44 (comment)](#44 (comment)): I've also now noticed that RenameVersion is also not correctly escaping the filename, it's only escaping the mod's name, and not the version, which is what causes mods that use build metadata in the version (+build.1234) to fail, so that one should need a similar fix of encoding the filename. Signed-off-by: Angel Pons <[email protected]> --------- Signed-off-by: Angel Pons <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.