Skip to content

Commit

Permalink
Merge pull request #2 from samuelattwood/fix-fetch-newer
Browse files Browse the repository at this point in the history
Fixing bug in fetch newer with PackageVersion
  • Loading branch information
samuelattwood committed Feb 1, 2023
2 parents ed4ab48 + 462ab96 commit 6bd5d5e
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -661,20 +661,21 @@ func collectNonStoredVersions(versions repo.ChartVersions, storedVersions repo.C
}
if !stored {
if fetch == strings.ToLower("newer") {
var semVer, storedSemVer *semver.Version
var semVer *semver.Version
semVer, err := semver.NewVersion(version.Version)
if err != nil {
logrus.Error(err)
continue
}
if len(storedVersions) > 0 {
storedSemVer, err = semver.NewVersion(storedVersions[0].Version)
strippedStoredLatest := conform.StripPackageVersion(storedVersions[0].Version)
storedLatestSemVer, err := semver.NewVersion(strippedStoredLatest)
if err != nil {
logrus.Error(err)
continue
}
if semVer.GreaterThan(storedSemVer) {
logrus.Debugf("Version: %s > %s\n", semVer.String(), storedSemVer.String())
if semVer.GreaterThan(storedLatestSemVer) {
logrus.Debugf("Version: %s > %s\n", semVer.String(), storedVersions[0].Version)
nonStoredVersions = append(nonStoredVersions, version)
}
} else {
Expand Down

0 comments on commit 6bd5d5e

Please sign in to comment.