Path command extension #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samolego
approved these changes
May 27, 2022
| @@ -25,6 +25,11 @@ public BlockInteractEventImpl() { | |||
| */ | |||
| @Override | |||
| public InteractionResult interact(Player player, Level world, InteractionHand hand, BlockHitResult blockHitResult) { | |||
| return BlockEvent.onBlockInteract(player, world, blockHitResult.getBlockPos()); | |||
| // check in if clause prevents crash (check for server side) on clients | |||
| // and prevents executing event handler twice (check for main hand) | |||
There was a problem hiding this comment.
Just minor clarification: as player's npc will be null on client, it won't crash (at least it shouldn't :) ).
However, it will still double trigger (& it's clearer to check the side than relying on nulls).
|
Hi, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi samolego!
I've extended the path command with a few useful features which ease access for users who want to change the path easily via commands and not in an interactive manner. (For example I use this for automatic and dynamic changes of my Taterzen NPCs ingame.)
It is actually possible to mix both editing modes, i.e. you can enter the interactive editor and still use only commands for editing, but will get visual feedback (e.g. you add a node via commandline and the redstone block appears in the world accordingly).
I have also extended the documentation accordingly. See docs/getting_started/path.md.
Best regards
Zacrain