[master] Add x509_v2 SSH wrapper, emulate x509.certificate_managed during state.apply
#65654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
x509_v2 SSH wrapper, emulate x509.certificate_managed during state.applyx509_v2 SSH wrapper, emulate x509.certificate_managed during state.apply
lkubb
force-pushed
the
x509v2-ssh-wrapper
branch
2 times, most recently
from
e171d03
to
a832a20
Compare
lkubb
force-pushed
the
x509v2-ssh-wrapper
branch
from
a832a20
to
540ad4d
Compare
lkubb
force-pushed
the
x509v2-ssh-wrapper
branch
2 times, most recently
from
639ae1e
to
83ea4eb
Compare
lkubb
force-pushed
the
x509v2-ssh-wrapper
branch
from
4f77102
to
b897b29
Compare
lkubb
force-pushed
the
x509v2-ssh-wrapper
branch
from
1f72609
to
c0cdad9
Compare
twangboy
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
x509.create_certificateandx509.get_signing_policycertificate_managed(essentially a very sophisticated Jinja macro) - certificates can now be managed via salt-sshstate.applyeven when they are issued on a remote (this should also work for other salt-ssh minions from the roster as the CA, but it's hard to write tests for)encodingtofile.managedvia thex509_v2state module was impossible (I don't think anyone uses this though)What issues does this PR fix or reference?
Fixes: #65728
Fixes: #40943 (actually fixes the author's issue - the title asks for a different thing than is necessary)
Previous Behavior
x509_v2modules could not request remotely signed certificates when run via salt-sshNew Behavior
Merge requirements satisfied?
Commits signed with GPG?
Yes