Add pain.001.001.09 and pain.008.001.08 #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for generating pain.001.001.09 and pain.008.001.08 files.
The relevant difference is surprisingly small.
For pain.001.001.09 the difference for the requested execution date is that it now supports date and date time for facilitating instant transfers eventually. In this pull request I skipped the changes to allow passing a time or date time value instead of the date. It should be a relatively simple addition, however it does require adapting the
validate_requested_date_afterfunction to a higher degree than I would want to add in this pull request.I would appreciate any feedback on this