Fix: added mostly-proper Unicode support. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note, the single character decoding obviously won't work with multi code-unit characters. To fix that, the code-unit by code-unit decoding would need to be modified to detect code-units in the surrogate range, and continue decoding more code-units until a complete code-point is found. Fortunately, most languages are within the Basic Multilingual Plane.
huffman
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, the single character decoding obviously won't work with multi code-unit characters. To fix that, the code-unit by code-unit decoding would need to be modified to detect code-units in the surrogate range, and continue decoding more code-units until a complete code-point is found. Fortunately, most languages are within the Basic Multilingual Plane.
Note, a USB capture with non-ascii characters can be found in support ticket 83241