Add make_set function for DisjointSets #38692
Open
+88
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoudert
suggested changes
Sep 22, 2024
| cdef int *new_parent, *new_rank, *new_mcr, *new_size | ||
|
|
||
| cdef int *int_array = <int *> sig_malloc( 4*(n+1) * sizeof(int) ) | ||
| if int_array is NULL: |
There was a problem hiding this comment.
Do you really want to call free on NULL ?
| new_rank = int_array + (n + 1) | ||
| new_mcr = int_array + (2*n + 2) | ||
| new_size = int_array + (3 * n + 3) | ||
| for i from 0 <= i < n: |
| @@ -834,6 +854,43 @@ cdef class DisjointSet_of_hashables(DisjointSet_class): | |||
| cdef int j = <int> self._el_to_int[f] | |||
| OP_join(self._nodes, i, j) | |||
|
|
|||
| def make_set(self, new_elt = None): | |||
| r""" | |||
| Return a new disjoint set with an additional item. | |||
There was a problem hiding this comment.
You are not returning a new set, you are adding one new element to the set
| new_size = int_array + (3 * n + 3) | ||
| for i from 0 <= i < n: | ||
| new_parent[i] = OP.parent[i] | ||
| new_rank[i] = OP.rank[i] |
There was a problem hiding this comment.
why not using low level memcpy method ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #35599 by adding a
make_setfunction toDisjointSetusingOrbitPartitions. The documentation links to wikipedia.From wikipedia, the method should be done in place and therefore there is no return
📝 Checklist
⌛ Dependencies
#35599