Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests with singular 4.4.0p3 #38689

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix tests with singular 4.4.0p3 #38689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sage/libs/singular/option.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ this::

sage: with opt_ctx(red_tail=False, red_sb=False):
....: std(I)[-1]
d^2*e^6 + 8*c^3 + ...
d^2*e^6 +...8*c^3 + ...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of these is supposed to be tail-reduced and the other not... we could do e.g. reduced = std(I)[-1] in the first case and notreduced = std(I)[-1] in the second, with the test then being reduced != notreduced?


However, this does not affect the global state::

Expand Down
2 changes: 1 addition & 1 deletion src/sage/rings/polynomial/multi_polynomial_ideal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@
The Groebner basis modulo any product of the prime factors is also non-trivial::

sage: I.change_ring(P.change_ring(IntegerModRing(2 * 7))).groebner_basis()
[x + 9*y + 13*z, y^2 + 3*y, y*z + 7*y + 6, 2*y + 6, z^2 + 3, 2*z + 10]
[x + ..., y^2 + 3*y, y*z + 7*y + 6, 2*y + 6, z^2 + 3, 2*z + 10]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text above this test says that it's checking that the basis is non-trivial, so we could probably fix this one forever by simply comparing it to the trivial basis and looking for False


Modulo any other prime the Groebner basis is trivial so there are
no other solutions. For example::
Expand Down
Loading