Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: re-enable run on pull_request #43

Merged
merged 1 commit into from
Sep 27, 2024
Merged

ci: re-enable run on pull_request #43

merged 1 commit into from
Sep 27, 2024

Conversation

achrinza
Copy link
Contributor

ci: re-enable run on pull_request

Pull request trigger is necessary for accurate testing of the "impact" of a PR, whilst push trigger is necessary for accurate coverage diffs on PRs that are behind base branch during CI trigger.

Partially reverts: 21d0f1e

Signed-off-by: Rifa Achrinza [email protected]

@coveralls
Copy link

coveralls commented Sep 27, 2024

Pull Request Test Coverage Report for Build 11063347523

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 3.462%

Totals Coverage Status
Change from base Build 11054313834: 0.0%
Covered Lines: 3
Relevant Lines: 190

💛 - Coveralls

Pull request trigger is necessary for accurate testing of the "impact" of a PR,
whilst push trigger is necessary for accurate coverage diffs on PRs that are
behind base branch during CI trigger.

Partially reverts: 21d0f1e

Signed-off-by: Rifa Achrinza <[email protected]>
@achrinza achrinza merged commit 246224a into main Sep 27, 2024
13 checks passed
@achrinza achrinza deleted the ci/trigger branch September 27, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants