add default namespaced events #354
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds the namespaced version of the default events. such
on:click. There is probably some clever way to avoid duplication, but I preferred to follow how is it done.I'm not sure what will happen if someone tries to define an event with the same name, I suppose we can move the location of the
extends CustomEventHandlersNamespaced<T>if that's reported as an issue.. and that will fix it? 🤔Somehow prettier formatted the jsdoc comments, I suspect a plugin I have installed, it shouldn't cause issues with the regular formatting as it won't touch comment contents.
closes solidjs/solid#1939
asked for input in the TS channel and seems like a good idea to include this https://discord.com/channels/722131463138705510/783844647528955931/1291147473011736613