0.39.0 Updates #353
Merged
0.39.0 Updates #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add tests for event delegation and shadow dom * Retarget when walking up shadow DOM * Use composedPath where possible for bubbling events * Explicitly reset to original target --------- Co-authored-by: Oliver Coad <[email protected]>
…the object for `options` (#341) * allow `addEventListener` to use `handleEvent` syntax while using the object form for options * add type to client.d.ts * add type to lit-dom-expressions/src/index.ts * add to `assignProp` * add to `removeEventListener` on client.js * Update types * Update types * formatting * add `EventHandlerWithOptions` type * use dom-expressions `addEventListener` instead of the browser one for custom events. Move `oncapture` to its own conditional * add test for expected compile output * add test using jsdom to assert a handler with `once` only runs once
* preliminary support for ``bool:` * make code smaller * value of attribute should be empty when adding it to the dom * inline bool: attribute into the template when possible * fix prop name * undo space test
* Add tests for event delegation and shadow dom * Retarget when walking up shadow DOM * Use composedPath where possible for bubbling events * Explicitly reset to original target --------- Co-authored-by: Oliver Coad <[email protected]>
…the object for `options` (#341) * allow `addEventListener` to use `handleEvent` syntax while using the object form for options * add type to client.d.ts * add type to lit-dom-expressions/src/index.ts * add to `assignProp` * add to `removeEventListener` on client.js * Update types * Update types * formatting * add `EventHandlerWithOptions` type * use dom-expressions `addEventListener` instead of the browser one for custom events. Move `oncapture` to its own conditional * add test for expected compile output * add test using jsdom to assert a handler with `once` only runs once
* preliminary support for ``bool:` * make code smaller * value of attribute should be empty when adding it to the dom * inline bool: attribute into the template when possible * fix prop name * undo space test
…ow an error (#345) * export constants from dom-expressions server.js * export functions from dom-expressions server.js to match client.js exports, and make client-only functions throw on the serverside * add missing imports, add missing types --------- Co-authored-by: Ryan Carniato <[email protected]>
* validates whole partial * display a warning instead of an error * greatly improves the error message * improve readability * add `templateWithClosingTags` accumulated string for faithful validation * include dom-expressions comments in the validation * refactor validate function to make it more simple and show diffs next to error message * remove old comment * handle "content" outside tags, handle edge case: tr/td * fix typos * doesnt need capturing * handle text nodes moves * use `#text` instead of an underscore, it's less cryptic * improve comments --------- Co-authored-by: Ryan Carniato <[email protected]>
This reverts commit 95f3af4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release updates and adds some new features:
importNode- @titoBouzoutbool:attribute namespace - @titoBouzout"is"as detection for custom element - @titoBouzout