Add CORS support #66
Open
Add CORS support #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Have you had a chance to try this out? |
|
Hi—thanks for the contribution. Unfortunately I haven't had a chance to check it out yet, as I'll need to do some non-trivial setup on my end to get it tested, and (perhaps more meaningfully) deployed to the heroku instance of this app. I likely won't have the cycles to do that his month, but I'll try to see if I can work on it in April. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for maintaining this reconciliation endpoint.
We (the Reconciliation CG) are trying to revamp this API, and as part of that we are trying to encourage migration to CORS instead of JSONP. See the corresponding issue: reconciliation-api/specs#19
This PR should add CORS support to your reconciliation endpoint, although I have not tested it (as I don't do Ruby).