Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add advisory for unsound problem in scanner-rust #2000

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add advisory for unsound problem in scanner-rust #2000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions crates/scanner-rust/RUSTSEC-0000-0000.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "scanner-rust"
date = "2024-07-06"
url = "https://github.com/magiclen/scanner-rust/issues/2"
informational = "unsound"
categories = ["format-injection"]

[affected]
functions = { "scanner-rust::ScannerU8SliceAscii::new" = ["<= 2.0.17"] }

[versions]
patched = []
```

# Create and parse non-utf8 str in `ScannerU8SliceAscii`

`ScannerU8SliceAscii` uses lots of unsafe function `from_utf8_unchecked` to directly
convert the `[u8]` to `str` and then parse it to target type.

However, there is no validation in `ScannerU8SliceAscii::new` to guarantee the `data`
is Ascii. So if the `ScannerU8SliceAscii` is used to scan the non-utf8 bytes, non-utf8
str would be generated and passed it to `parse` which might lead to undefined behaviors.