Note that selecting VS lang packs is optional #4025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Sep 18, 2024
rami3l
approved these changes
Sep 18, 2024
|
@ChrisDenton Thanks a lot :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust used to mangle linker output for non-ascii error messages. The workaround was to install the Visual Studio English Language Pack so that most error messages would be mostly ascii (file names aside). However this was fixed in Rust 1.71 (released July 2023) so it's no longer required. We should still recommend installing the English pack both for the sake of compatibility and because rustc's output is itself still in English unless a nightly feature is used.