Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: use the correct span for doctests #130582

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rustdoc: use the correct span for doctests #130582

wants to merge 1 commit into from
+41 −12

Conversation

notriddle
Copy link
Contributor

Fixes #130470

@rustbot
Copy link
Collaborator

rustbot commented Sep 19, 2024

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 19, 2024
notriddle
notriddle commented Sep 19, 2024
View reviewed changes
tests/rustdoc-ui/doctest/doctest-output.stdout
@@ -1,7 +1,7 @@

running 3 tests
test $DIR/doctest-output.rs - (line 8) ... ok
test $DIR/doctest-output.rs - ExpandedStruct (line 24) ... ok
test $DIR/doctest-output.rs - ExpandedStruct (line 25) ... ok
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 25 is here, and this seems fine.

rust/tests/rustdoc-ui/doctest/doctest-output.rs

Line 25 in 1870efb

/// ```

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member

Ah you forgot to fmt the code. :)

@notriddle
Copy link
Contributor Author

@GuillaumeGomez Yes, I did...

@GuillaumeGomez
Copy link
Member

Happens to the best of us. 😉

r=me once CI pass. 👍

@notriddle
Copy link
Contributor Author

@bors r=GuillaumeGomez rollup

@bors
Copy link
Contributor

bors commented Sep 19, 2024

📌 Commit 65e432d has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rustdoc reports issues against lib.rs rather than an include_str!'d file
5 participants
@notriddle @rustbot @rust-log-analyzer @GuillaumeGomez @bors