Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize const {slice,array}::from_mut #130538

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ultrabear
Copy link
Contributor

This PR stabilizes the following APIs as const stable as of rust 1.83:

// core::array
pub const fn from_mut<T>(s: &mut T) -> &mut [T; 1];

// core::slice
pub const fn from_mut<T>(s: &mut T) -> &mut [T];

This is made possible by const_mut_refs being stabilized (yay).

Tracking issue: #90206

@rustbot
Copy link
Collaborator

rustbot commented Sep 19, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 19, 2024
@cuviper
Copy link
Member

cuviper commented Sep 19, 2024

I think this still needs a stabilization FCP.

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 19, 2024
@rustbot rustbot assigned dtolnay and unassigned cuviper Sep 19, 2024
@rust-log-analyzer

This comment has been minimized.

@ultrabear
Copy link
Contributor Author

I think this still needs a stabilization FCP.

Yep, this was opened because the original issue already had an FCP for the half of it that got merged, and an FCP cant happen on the same issue twice (informed by Jubilee)

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@ultrabear
Copy link
Contributor Author

force pushed to squash what was 3 commits of failing bootstrap

@ultrabear ultrabear changed the title Stabilize {slice,array}::from_mut Stabilize const {slice,array}::from_mut Sep 19, 2024
@workingjubilee workingjubilee added needs-fcp This change is insta-stable, so needs a completed FCP to proceed. I-libs-api-nominated Nominated for discussion during a libs-api team meeting. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-libs-api-nominated Nominated for discussion during a libs-api team meeting. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants