Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: Set the dylib path when building books with rustdoc #130536

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bootstrap: Set the dylib path when building books with rustdoc #130536

wants to merge 1 commit into from
+11 −9

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Sep 18, 2024

The library path is needed when the toolchain has been configured with
[rust] rpath = false. Otherwise, building the reference book will get
an error when it tries to run rustdoc, like:

rustdoc: error while loading shared libraries: librustc_driver-2ec457c3b8826b72.so

@cuviper
bootstrap: Set the dylib path when building books with rustdoc
de4c897 
The library path is needed when the toolchain has been configured with
`[rust] rpath = false`. Otherwise, building the reference book will get
an error when it tries to run rustdoc, like:

    rustdoc: error while loading shared libraries: librustc_driver-2ec457c3b8826b72.so
@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 18, 2024
@cuviper
Copy link
Member Author

cuviper commented Sep 18, 2024

This might be worth a backport too, because this is a regression from #128215.

@rustbot label beta-nominated

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cuviper @rustbot @Mark-Simulacrum