Require libclang 9.0 or newer #2932
Open
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I'd rather do a warning than a hard error. We've had issues detecting versions in e.g. Apple clang. |
Adds a check for the loaded libclang version and logs a warning if the version is unsupported.
|
I have changed the error to a warning, printed using the log crate. If the user has the logging feature disabled they won't see it. |
emilio
approved these changes
Sep 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
It was removed from the merge queue for some reason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check for the loaded libclang version and returns an error if the version is unsupported.