Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @ember/string to v4 #9011

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 6, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@ember/string 3.1.1 -> 4.0.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@bors
Copy link
Contributor

bors commented Jul 6, 2024

☔ The latest upstream changes (presumably 3e3c470) made this pull request unmergeable. Please resolve the merge conflicts.

@renovate renovate bot force-pushed the renovate/ember-string-4.x branch from 77083bd to ac7b272 Compare July 6, 2024 07:29
@bors
Copy link
Contributor

bors commented Jul 7, 2024

☔ The latest upstream changes (presumably a8f3ae0) made this pull request unmergeable. Please resolve the merge conflicts.

@renovate renovate bot force-pushed the renovate/ember-string-4.x branch from ac7b272 to ebd12c9 Compare July 7, 2024 07:19
@bors
Copy link
Contributor

bors commented Jul 7, 2024

☔ The latest upstream changes (presumably 9188850) made this pull request unmergeable. Please resolve the merge conflicts.

@renovate renovate bot force-pushed the renovate/ember-string-4.x branch from ebd12c9 to 9db7627 Compare July 7, 2024 20:26
@bors
Copy link
Contributor

bors commented Jul 9, 2024

☔ The latest upstream changes (presumably 67c0877) made this pull request unmergeable. Please resolve the merge conflicts.

@renovate renovate bot force-pushed the renovate/ember-string-4.x branch 3 times, most recently from a40c9ba to 069ba37 Compare July 11, 2024 09:28
@bors
Copy link
Contributor

bors commented Jul 11, 2024

☔ The latest upstream changes (presumably 81f3cf9) made this pull request unmergeable. Please resolve the merge conflicts.

@renovate renovate bot force-pushed the renovate/ember-string-4.x branch 2 times, most recently from c3780bd to 94cdbd0 Compare July 12, 2024 13:19
@bors
Copy link
Contributor

bors commented Jul 15, 2024

☔ The latest upstream changes (presumably fa0a007) made this pull request unmergeable. Please resolve the merge conflicts.

@renovate renovate bot force-pushed the renovate/ember-string-4.x branch from 94cdbd0 to dc318fd Compare July 15, 2024 06:32
@bors
Copy link
Contributor

bors commented Jul 15, 2024

☔ The latest upstream changes (presumably 801cc33) made this pull request unmergeable. Please resolve the merge conflicts.

@renovate renovate bot force-pushed the renovate/ember-string-4.x branch 2 times, most recently from 067f115 to c5a30b4 Compare July 15, 2024 17:32
@bors
Copy link
Contributor

bors commented Jul 20, 2024

☔ The latest upstream changes (presumably 1c8c8ff) made this pull request unmergeable. Please resolve the merge conflicts.

@renovate renovate bot force-pushed the renovate/ember-string-4.x branch from c5a30b4 to a370929 Compare July 20, 2024 04:19
... instead of relying on the package itself which is causing build issues again and again
Copy link
Contributor Author

renovate bot commented Jul 24, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@bors
Copy link
Contributor

bors commented Jul 24, 2024

☔ The latest upstream changes (presumably 4961e64) made this pull request unmergeable. Please resolve the merge conflicts.

@@ -0,0 +1,9 @@
// Imported from the `@ember/string` package to avoid build issues...
Copy link

@NullVoxPopuli NullVoxPopuli Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, if this is all you need, then it's probably more valuable to try to remove the dep

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's all we need in the app itself, but it looks like e.g. ember-tooltips needs more

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like ember-tooltips could also do with a v2 conversion 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants