riscv: add mcountinhibit module
#213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romancardenas
requested changes
May 21, 2024
There was a problem hiding this comment.
Thanks for the PR!
About returning a result/option: I think it is better if we assert for now and discuss in #212 about transitioning to a panic-less strategy
rmsyn
force-pushed
the
register/mcountinhibit
branch
3 times, most recently
from
10f4b25
to
b1acbfd
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Clippy is complaining in merge queue: https://github.com/rust-embedded/riscv/actions/runs/9201547297 @rmsyn please can you update your PR? |
rmsyn
force-pushed
the
register/mcountinhibit
branch
from
b1acbfd
to
6e29920
Compare
Did something change from the PR CI runs? I fixed the comment clippy was unhappy with, but it was unrelated to my code changes... |
rmsyn
force-pushed
the
register/mcountinhibit
branch
from
6e29920
to
96b548d
Compare
Adds the `riscv::register::mcountinhibit` module for the `mcountinhibit` CSR.
rmsyn
force-pushed
the
register/mcountinhibit
branch
from
96b548d
to
93c6d40
Compare
romancardenas
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
riscv::register::mcountinhibitmodule for themcountinhibitCSR.