-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add Dependabot #435
base: master
Are you sure you want to change the base?
ci: Add Dependabot #435
Conversation
Enable [Dependabot](https://docs.github.com/en/code-security/dependabot) to open PRs to update dependencies.
Pull Request Test Coverage Report for Build 9847433142Details
💛 - Coveralls |
@nh13 Hi, Nils. Could you please review and merge this PR to enable Dependabot to update dependencies in |
@sjackman I am not a maintainer unfortunately. CC: @FelixMoelder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi and thanks for adding Dependabot! Felix and Johannes are both on vacation at the moment. Just a small change before we can get this merged
commit-message: | ||
# Prefix all commit messages with "deps: ", which should be | ||
# accepted as a conventional commit and trigger release-please | ||
prefix: "deps" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is necessary. Check out our Dependabot configuration for datavzrd (another software of ours). This is not specified and the PRs are titles with build(deps):. I don't think deps: is part of the angular convention that conventional commits and release-please rely on.
commit-message: | |
# Prefix all commit messages with "deps: ", which should be | |
# accepted as a conventional commit and trigger release-please | |
prefix: "deps" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deps:
is the convention used by both rust-bio
and rust-bio-types
:
https://github.com/rust-bio/rust-bio/blob/f726f3511f7286b687687b811441599b98f1dc82/.github/dependabot.yml#L7-L10
https://github.com/rust-bio/rust-bio-types/blob/e36648bd3a0f8c5cd711d060bd647f369a2c954e/.github/dependabot.yml#L7-L10
Can you please confirm that rust-bio/rust-htslib
wishes to use a different convention build(deps):
than the convention deps:
used by both rust-bio
and rust-bio-types
? I have no preference. I just want to confirm that the deviation is intentional.
Enable Dependabot to open PRs to update dependencies.
Related PR in
rust-bio/rust-bio
: