Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Dependabot #435

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sjackman
Copy link
Contributor

@sjackman sjackman commented Jul 8, 2024

Enable Dependabot to open PRs to update dependencies.

Related PR in rust-bio/rust-bio:

Enable [Dependabot](https://docs.github.com/en/code-security/dependabot) to open PRs to update dependencies.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9847433142

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.692%

Totals Coverage Status
Change from base Build 9223286963: 0.0%
Covered Lines: 2484
Relevant Lines: 3117

💛 - Coveralls

@sjackman
Copy link
Contributor Author

@nh13 Hi, Nils. Could you please review and merge this PR to enable Dependabot to update dependencies in rust-htslib? Dependabot is being using in both bio and bio-types.

@nh13
Copy link
Contributor

nh13 commented Jul 23, 2024

@sjackman I am not a maintainer unfortunately. CC: @FelixMoelder

Copy link
Contributor

@fxwiegand fxwiegand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi and thanks for adding Dependabot! Felix and Johannes are both on vacation at the moment. Just a small change before we can get this merged ☺️

Comment on lines +7 to +10
commit-message:
# Prefix all commit messages with "deps: ", which should be
# accepted as a conventional commit and trigger release-please
prefix: "deps"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary. Check out our Dependabot configuration for datavzrd (another software of ours). This is not specified and the PRs are titles with build(deps):. I don't think deps: is part of the angular convention that conventional commits and release-please rely on.

Suggested change
commit-message:
# Prefix all commit messages with "deps: ", which should be
# accepted as a conventional commit and trigger release-please
prefix: "deps"

Copy link
Contributor Author

@sjackman sjackman Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deps: is the convention used by both rust-bio and rust-bio-types:
https://github.com/rust-bio/rust-bio/blob/f726f3511f7286b687687b811441599b98f1dc82/.github/dependabot.yml#L7-L10
https://github.com/rust-bio/rust-bio-types/blob/e36648bd3a0f8c5cd711d060bd647f369a2c954e/.github/dependabot.yml#L7-L10

Can you please confirm that rust-bio/rust-htslib wishes to use a different convention build(deps): than the convention deps: used by both rust-bio and rust-bio-types? I have no preference. I just want to confirm that the deviation is intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants