Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed redundant tailwind classname #2462

Closed

Conversation

Jay-Karia
Copy link
Contributor

Fixes Issue

Closes #2447

Changes proposed

Removes extra tailwind class: hidden

Copy link

vercel bot commented Aug 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2024 3:06pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Jay-Karia, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jay-Karia its not redundant, its for mobile view to hide the top nav-links and show them on tablets/desk view.

image

@Jay-Karia
Copy link
Contributor Author

Then maybe we need to mention md: or lg:

@rupali-codes
Copy link
Owner

Then maybe we need to mention md: or lg:

we have mentioned it as md:block so it will displayed for tablets/desk view and it will remain hidden for mobile

@Jay-Karia Jay-Karia deleted the refactor/tailwind-classnames branch August 8, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: refactor Refactoring the codebase priority: medium Modifying an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Two class names with same css properties
2 participants