fix: info buttons weren't showing text on mouse up #2408 #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielBittar
requested review from
CBID2,
rupali-codes,
Anmol-Baranwal and
aftabrehan
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This was referenced Jul 10, 2024
Closed
GabrielBittar
changed the title
GabrielBittar
changed the title
3 tasks
|
I read all the requests and tried to solve them all in the new commits. Hope it works fine now. |
rupali-codes
approved these changes
Jul 23, 2024
|
@CBID2 & @Anmol-Baranwal could you review this please. |
Anmol-Baranwal
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2408
Changes proposed
Erased not used subcategories and cleaned their identifiers, changed them from 'name-name' to name_name, using TS pattern, so now infos are showing correctly. Also added subcategory description for DevOps > Automation Tools.
Notes for editors
In order to keep showing the "3d" at the subcategory Frontend > 3D Libraries, I had to use some regex at TopBar.tsx, line 29 to change it, since TS won't accept variables names starting by numbers, so the variable had to be called "three_d_libraries".
Thanks for letting me start here! Hope this solves the bug.