Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve the Support Section #2253

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Conversation

sarava338
Copy link
Contributor

@sarava338 sarava338 commented Feb 2, 2024

Fixes Issue

Closes #2242

Changes proposed

README.md support section was updated.

Screenshots

Before
Before

After
After

Note to reviewers

Can I be a cotributor ?

Copy link

vercel bot commented Feb 2, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel.

@rupali-codes first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, sarava338, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@CBID2 CBID2 closed this Feb 2, 2024
@CBID2
Copy link
Collaborator

CBID2 commented Feb 2, 2024

Hi @sarava338. I closed your PR because it was not assigned to you yet. Please read our Contributing guide to get started.

@sarava338
Copy link
Contributor Author

sarava338 commented Feb 2, 2024

Hi @sarava338. I closed your PR because it was not assigned to you yet. Please read our Contributing guide to get started.

Hi @CBID2, So May I know when #2242 be unlocked and it can be assigned to me ?

@CBID2
Copy link
Collaborator

CBID2 commented Feb 2, 2024

Hi @sarava338. I closed your PR because it was not assigned to you yet. Please read our Contributing guide to get started.

Hi @CBID2, So May I know when #2242 be unlocked and it can be assigned to me ?

I just unlocked it @sarava338. Just mention your name in the comment section.

@Anmol-Baranwal
Copy link
Collaborator

@sarava338
Just to let you know, this isn't the correct way to link the issue.

image

What will happen is, even if this pull request is merged; the corresponding issue will not be closed.

You can read this: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@CBID2 CBID2 reopened this Feb 2, 2024
@CBID2
Copy link
Collaborator

CBID2 commented Feb 2, 2024

To add onto @Anmol-Baranwal's point @sarava338, I reopened this PR so no need to create a new one.

@sarava338
Copy link
Contributor Author

@sarava338
Just to let you know, this isn't the correct way to link the issue.

image

What will happen is, even if this pull request is merged; the corresponding issue will not be closed.

You can read this: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Hi @Anmol-Baranwal, oooh, I don't know about this. This is my first OSP. Thanks for letting me know.

@sarava338 sarava338 changed the title Improved the Support Section #2242 Closes #2242 Improve the Support Section Feb 3, 2024
@CBID2 CBID2 changed the title Closes #2242 Improve the Support Section [docs] Improve the Support Section Feb 3, 2024
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Sarava33! :) As you continue your open source journey remember the following

  1. Read the contributing guide before you start your contribution
  2. Use keywords when linking your issue

@CBID2
Copy link
Collaborator

CBID2 commented Feb 3, 2024

@rupali-codes, please approve deployment.
@Anmol-Baranwal, it's your turn

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

No need of deployment, making a change in Readme won't break anything :)

@Anmol-Baranwal Anmol-Baranwal added the status: ready-to-merge Approved & its ready-to-merge label Feb 3, 2024
@sarava338
Copy link
Contributor Author

Great job @Sarava33! :) As you continue your open source journey remember the following

  1. Read the contributing guide before you start your contribution
  2. Use keywords when linking your issue

Yeah sure, Thanks for the advise 👍🏼

Copy link
Collaborator

@aftabrehan aftabrehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

@Anmol-Baranwal Anmol-Baranwal linked an issue Feb 3, 2024 that may be closed by this pull request
5 tasks
@CBID2
Copy link
Collaborator

CBID2 commented Feb 3, 2024

@rupali-codes, can you deploy this? It won't merge if you don't.

Copy link

vercel bot commented Feb 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2024 4:28pm

@CBID2 CBID2 merged commit 11cec92 into rupali-codes:main Feb 3, 2024
7 checks passed
@sarava338 sarava338 deleted the sarava338-2242 branch February 3, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-to-merge Approved & its ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Improve the Support Section
4 participants