[bug]: fix breadcrumbs #2249
[bug]: fix breadcrumbs #2249
Conversation
sanjeevkumar321
requested review from
Anmol-Baranwal,
CBID2,
rupali-codes and
aftabrehan
as code owners
|
Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel. @rupali-codes first needs to authorize it. |
github-actions
bot
added
bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@rupali-codes |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@sanjeevkumar321 hey, can you fix this please?
|
|
Hello @rupali-codes thank for notice this issue , kindly verify once |
|
@aftabrehan, it is your turn. |
There was a problem hiding this comment.
Excellent PR, @sanjeevkumar321 🚀
Could you please double-check? The following Regex isn't working as expected.
The sidebar title and the breadcrumbs title should be the same. Feel free to reach out if you need any help. Thank you!
Hello @aftabrehan thanks for this issue kindly verify it. |
Hi @Anmol-Baranwal kindly verify ones |
|
@Anmol-Baranwal, @CBID2, please help review and merge this PR. Thank you! |
|
@rupali-codes |
rupali-codes
dismissed stale reviews from CBID2 and aftabrehan
The merge-base changed after approval.
|
hi @Anmol-Baranwal why Merging is blocked can you please check it ? |
|
Hi @sanjeevkumar321 |
database/open_source/tutorials.json
Outdated
There was a problem hiding this comment.
Hey, we've written it as os-tutorials because in future if we'd have tutorials then it won't create conflicts
There was a problem hiding this comment.
@sanjeevkumar321, so you would need to use os-tutorials for the subcategory name and the file name as well. Please, make sure to keep it consistent at all places.
There was a problem hiding this comment.
Hey, can you please follow the same naming convention for each subcategory? like for nlp make it natural-language-processing and so on
There was a problem hiding this comment.
@sanjeevkumar321, If you need any help, feel free to let us know.
|
@rupali-codes |
|
@rupali-codes @aftabrehan |
|
Found some merge conflicts that need fixing @sanjeevkumar321. |
|
Closing the PR due to being inactive. |
Fixes Issue
Closes #2248
Changes proposed
When we have category name of two words or more. It has - in the breadcrumbs which should be removed
Screenshots
Note to reviewers