Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG] Align pagination buttons to bottom #2239

Conversation

mfrezghi
Copy link
Contributor

Fixes Issue

Closes #2238

Changes proposed

  • Added a numberOfCards variable to [...subcategory.tsx] to track the number of cards on each page.
  • Used numberOfCards within Pagination.tsx to calculate if there are 3 or less cards in a page.
  • Added a div that adds padding above the pagination element if there are 3 or less cards on the page.

Screenshots

Screenshot 2024-01-25 at 10 44 12 AM

Note to reviewers

I am very new to this so please criticize.

Copy link

vercel bot commented Jan 25, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel.

@rupali-codes first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, mfrezghi, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@CBID2 CBID2 changed the title Closes #2238 BUG] Align pagination buttons to bottom Jan 25, 2024
@Anmol-Baranwal
Copy link
Collaborator

@rupali-codes
Need deployment authorization :)

Copy link

vercel bot commented Jan 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2024 9:02am

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@aftabrehan @CBID2 @rupali-codes

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@CBID2
Copy link
Collaborator

CBID2 commented Jan 28, 2024

@aftabrehan it's your turn to review! :)

@Anmol-Baranwal Anmol-Baranwal added the status: ready-to-merge Approved & its ready-to-merge label Jan 28, 2024
Copy link
Collaborator

@aftabrehan aftabrehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me. However, why are there still two pagination components?

Screenshot 2024-01-29 at 8 11 16 AM

cc @rupali-codes @CBID2 @Anmol-Baranwal

@CBID2
Copy link
Collaborator

CBID2 commented Jan 29, 2024

This PR looks good to me. However, why are there still two pagination components?

Screenshot 2024-01-29 at 8 11 16 AM

cc @rupali-codes @CBID2 @Anmol-Baranwal

Ooh, good catch @aftabrehan. I'm not too sure

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rupali-codes rupali-codes merged commit eadaa03 into rupali-codes:main Jan 29, 2024
11 checks passed
@mfrezghi mfrezghi deleted the Align-pagination-buttons-to-bottom-#2238 branch January 29, 2024 18:16
@mfrezghi
Copy link
Contributor Author

Thank you!

@Anmol-Baranwal
Copy link
Collaborator

Thank you!

Thank you for your contribution!
We was slightly busy due to rebranding, but we truly appreciate your contribution 🙌
There might be more issues now, be tuned!

@mfrezghi
Copy link
Contributor Author

Will do. The rebranding looks amazing by the way 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-to-merge Approved & its ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Align pagination buttons to bottom
5 participants