Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add searchbar for mobile devices (new design) #2226

Merged
merged 3 commits into from
Jan 9, 2024
Merged

feat: add searchbar for mobile devices (new design) #2226

merged 3 commits into from
Jan 9, 2024

Conversation

heysolomon
Copy link
Contributor

@heysolomon heysolomon commented Dec 29, 2023 •
edited
Loading

Fixes Issue

Closes #2202

Changes proposed

  • added the new design for the searchbar

Screenshots

image

@vercel Vercel
Copy link

vercel bot commented Dec 29, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel.

@rupali-codes first needs to authorize it.

@github-actions github-actions bot added goal: new-feature New feature or request priority: high Making completely new feature labels Dec 29, 2023
github-actions[bot]
github-actions bot reviewed Dec 29, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, heysolomon, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@CBID2 CBID2 linked an issue Dec 29, 2023 that may be closed by this pull request
feat: add searchbar for mobile devices (new design) #2202
Closed
@Anmol-Baranwal
Copy link
Collaborator

@rupali-codes
Vercel deployment :)

@vercel Vercel
Copy link

vercel bot commented Dec 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 0:21am

rupali-codes
rupali-codes reviewed Dec 31, 2023
View reviewed changes
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anmol-Baranwal the deployment is failing

image

@heysolomon
Copy link
Contributor Author

@Anmol-Baranwal the deployment is failing

image

Sorry is it from my end?

I'm I supposed to fix something?

@rupali-codes
Copy link
Owner

@Anmol-Baranwal the deployment is failing
image

Sorry is it from my end?

I'm I supposed to fix something?

lemme try helping you

@heysolomon
Copy link
Contributor Author

@Anmol-Baranwal the deployment is failing
image

Sorry is it from my end?
I'm I supposed to fix something?

lemme try helping you

Okay, thank you!

aftabrehan
aftabrehan requested changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@aftabrehan aftabrehan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR, @heysolomon 💪 🚀 💯

It just needs minor adjustments and then we're good to go 🚀

components/SideNavbar/SideNavbarCategoryList.tsx Show resolved Hide resolved
@rupali-codes
Copy link
Owner

@heysolomon still working on it?

@heysolomon
Copy link
Contributor Author

@heysolomon still working on it?

yes

aftabrehan
aftabrehan approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@aftabrehan aftabrehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@aftabrehan
Copy link
Collaborator

The PR is okay, @rupali-codes, @Anmol-Baranwal, and @CBID2 please test on your end and help merge the PR.

Anmol-Baranwal
Anmol-Baranwal approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

Works as mentioned :)

@rupali-codes @CBID2
Review it.

rupali-codes
rupali-codes approved these changes Jan 9, 2024
View reviewed changes
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks perfect to me

Thanks @heysolomon

@rupali-codes rupali-codes merged commit 4a3f549 into rupali-codes:dev Jan 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@Anmol-Baranwal Anmol-Baranwal Anmol-Baranwal approved these changes

@rupali-codes rupali-codes rupali-codes approved these changes

@aftabrehan aftabrehan aftabrehan approved these changes

@CBID2 CBID2 Awaiting requested review from CBID2

Assignees

@heysolomon heysolomon

Labels
goal: new-feature New feature or request priority: high Making completely new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add searchbar for mobile devices (new design)
4 participants
@heysolomon @Anmol-Baranwal @rupali-codes @aftabrehan