Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added mantine link in frontend category #2222

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

Avas77
Copy link
Contributor

@Avas77 Avas77 commented Dec 25, 2023

Fixes Issue

Closes ##2221

Changes proposed

Add the Mantine link in the frontend category.

Screenshots

Screenshot 2023-12-25 at 20 37 39

Copy link

vercel bot commented Dec 25, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel.

@rupali-codes first needs to authorize it.

@github-actions github-actions bot added chore Might take time to finish goal: new-category Addition of new categories related contributions goal: new-feature New feature or request goal: new-link Addition of new links related contributions priority: high Making completely new feature priority: low Addition of new links/categories or doing any small task (e.g fixing typos) labels Dec 25, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Avas77, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link

vercel bot commented Dec 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2023 11:06am

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Avas77, is it only for react-components? if so, then please add this in frontend/react.json file

@Avas77
Copy link
Contributor Author

Avas77 commented Dec 25, 2023

Yes, It is a React component library that can be used with React-based frameworks Next.js, Gatsby, etc. Sure I will add it to react.json

@Avas77 Avas77 changed the title feat: Added mantine link in frontend category under UI libraries feat: Added mantine link in frontend category Dec 25, 2023
rupali-codes
rupali-codes previously approved these changes Dec 26, 2023
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

aftabrehan
aftabrehan previously approved these changes Dec 26, 2023
Copy link
Collaborator

@aftabrehan aftabrehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

Thanks for your contribution @Avas77.

database/frontend/react.json Outdated Show resolved Hide resolved
@aftabrehan aftabrehan dismissed stale reviews from rupali-codes and themself via c3aaec2 December 26, 2023 15:02
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@Anmol-Baranwal
Copy link
Collaborator

@rupali-codes @aftabrehan @CBID2
I requested your reviews because it was dismissed due to new changes.

Review and merge :)

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rupali-codes rupali-codes merged commit 5ea48dd into rupali-codes:main Dec 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Might take time to finish goal: new-category Addition of new categories related contributions goal: new-feature New feature or request goal: new-link Addition of new links related contributions priority: high Making completely new feature priority: low Addition of new links/categories or doing any small task (e.g fixing typos)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants