Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dsa 90 days roadmap link in others category #2201

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

Mathi-Alagan
Copy link
Contributor

@Mathi-Alagan Mathi-Alagan commented Dec 7, 2023

Fixes Issue

Closes #2200

Changes proposed

To add the DSA 90 days roadmap to placement link in the others category roadmap section.

Screenshots

image

Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2023 2:52pm

@github-actions github-actions bot added chore Might take time to finish goal: new-category Addition of new categories related contributions goal: new-link Addition of new links related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos) labels Dec 7, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Mathi-Alagan, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@Anmol-Baranwal
Copy link
Collaborator

What command did you run? Have you updated the dependencies? pnpm-lock.yaml is changed

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mathi-Alagan can you please uncommit pnpm-lock.yml

…icles.json file under data_structures"

This reverts commit 5fba34f.
@Mathi-Alagan
Copy link
Contributor Author

What command did you run? Have you updated the dependencies? pnpm-lock.yaml is changed

I installed pnpm, and ran the command pnpm run dev, but it throws exception. So I ran it using npm run dev. Now I have reverted the commit.

@Mathi-Alagan
Copy link
Contributor Author

@Mathi-Alagan can you please uncommit pnpm-lock.yml

@rupali-codes I have reverted the commit back, kindly review it once more and say any other changes to be made

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😁 @Anmol-Baranwal, your turn

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@Anmol-Baranwal Anmol-Baranwal added the status: ready-to-merge Approved & its ready-to-merge label Dec 8, 2023
@Mathi-Alagan
Copy link
Contributor Author

@rupali-codes could you review this pull request?

@Anmol-Baranwal
Copy link
Collaborator

@rupali-codes could you review this pull request?

@rupali-codes @aftabrehan
Please review and merge it :)

@CBID2
Copy link
Collaborator

CBID2 commented Dec 12, 2023

@aftabrehan, can you review and merge this please?

Copy link
Collaborator

@aftabrehan aftabrehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR, @Mathi-Alagan 💯

@aftabrehan aftabrehan merged commit d5bfe21 into rupali-codes:main Dec 12, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Might take time to finish goal: new-category Addition of new categories related contributions goal: new-link Addition of new links related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos) status: ready-to-merge Approved & its ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add] Adding a 90-Day DSA Roadmap Article by Takeuforward in the "Others" Category
5 participants