Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix formatting issues in CONTRIBUTING.md #2119

Merged
merged 2 commits into from
Oct 27, 2023
Merged

docs: fix formatting issues in CONTRIBUTING.md #2119

merged 2 commits into from
Oct 27, 2023

Conversation

0scvr
Copy link
Contributor

@0scvr 0scvr commented Oct 25, 2023 •
edited by CBID2
Loading

Fixes Issue

Closes #2111

Changes proposed

Fixed the formatting of some of the commit message examples in the contributing guidelines.

Screenshots

Note to reviewers

@vercel
Copy link

vercel bot commented Oct 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 8:53am

@github-actions github-actions bot added bug Something isn't working documentation Improvements or additions to documentation priority: medium Modifying an existing feature labels Oct 25, 2023
github-actions[bot]
github-actions bot reviewed Oct 25, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, 0scvr, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@CBID2 CBID2 marked this pull request as draft October 26, 2023 00:07
@CBID2
Copy link
Collaborator

CBID2 commented Oct 26, 2023

Hi @0scvr. Welcome to LinksHub! :) We don't accept unassigned pull requests, so I'm putting yours in draft mode for now. In the future, please wait until you have been assigned to the issue before you submit a pull request. Refer to our Contributing Guide to learn how to effectively contribute to the project. Happy Contributing! 😊

@Anmol-Baranwal
Copy link
Collaborator

@0scvr
Comment on the issue to get assigned.

@0scvr
Copy link
Contributor Author

0scvr commented Oct 26, 2023

Please assign me 😀

@0scvr 0scvr marked this pull request as ready for review October 26, 2023 07:45
@Anmol-Baranwal
Copy link
Collaborator

@0scvr
This is PR. Comment on issue or I'm going to assign it to someone else. Do it on priority basis.

@CBID2 CBID2 added priority: low Addition of new links/categories or doing any small task (e.g fixing typos) hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest and removed priority: medium Modifying an existing feature labels Oct 26, 2023
CBID2
CBID2 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @Anmol-Baranwal, your turn

Anmol-Baranwal
Anmol-Baranwal previously approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@CBID2 CBID2 added the status: ready-to-merge Approved & its ready-to-merge label Oct 26, 2023
CBID2
CBID2 requested changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @0scvr. The hyperlink in line 283 is not working(It says: 4. Use our Commit messages Guidelines for your changes.). Can you fix it please? Here's the link: https://github.com/rupali-codes/LinksHub/blob/main/CONTRIBUTING.md#commits-message-guidelines-

@CBID2 CBID2 mentioned this pull request Oct 26, 2023
Closed
4 tasks
@0scvr
Copy link
Contributor Author

0scvr commented Oct 27, 2023

Hi @0scvr. The hyperlink in line 283 is not working(It says: 4. Use our Commit messages Guidelines for your changes.). Can you fix it please? Here's the link: https://github.com/rupali-codes/LinksHub/blob/main/CONTRIBUTING.md#commits-message-guidelines-

Sure :)

@0scvr 0scvr force-pushed the 0scvr/contributing-formatting-issue branch from 2eef490 to 2fb3dc5 Compare October 27, 2023 08:52
Anmol-Baranwal
Anmol-Baranwal approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0scvr
Thanks so much for the changes. Appreciate it buddy.

rupali-codes
rupali-codes approved these changes Oct 27, 2023
View reviewed changes
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, lgtm

@rupali-codes rupali-codes merged commit 456ecc8 into rupali-codes:main Oct 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@CBID2 CBID2 CBID2 requested changes

@Anmol-Baranwal Anmol-Baranwal Anmol-Baranwal approved these changes

@rupali-codes rupali-codes rupali-codes approved these changes

Assignees

@0scvr 0scvr

Labels
bug Something isn't working documentation Improvements or additions to documentation hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest priority: low Addition of new links/categories or doing any small task (e.g fixing typos) status: ready-to-merge Approved & its ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] <formatting issues>
4 participants
@0scvr @CBID2 @Anmol-Baranwal @rupali-codes