Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revise errors in CODEOWNERS file #1830

Merged
merged 3 commits into from
Oct 8, 2023

Conversation

CBID2
Copy link
Collaborator

@CBID2 CBID2 commented Oct 6, 2023

Fixes Issue

Closes #1805

Changes proposed

One of the maintainers does not have write access to the repository, so this PR replaces their name with a maintainer that does have write access.

Screenshots

valid-code-ownersfile

Note to reviewers

N/A

@CBID2 CBID2 added priority: medium Modifying an existing feature hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest 🔒 staff-only Staff only task (Community can't do this issue) labels Oct 6, 2023
@CBID2 CBID2 self-assigned this Oct 6, 2023
@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 2:08am

@github-actions github-actions bot added the bug Something isn't working label Oct 6, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, CBID2, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@CBID2
Copy link
Collaborator Author

CBID2 commented Oct 6, 2023

I'm ready @Anmol-Baranwal and @rupali-codes

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

Thanks.

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rupali-codes rupali-codes merged commit e996cf9 into rupali-codes:main Oct 8, 2023
7 checks passed
@CBID2 CBID2 deleted the revising-code-owners-file branch October 9, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest priority: medium Modifying an existing feature 🔒 staff-only Staff only task (Community can't do this issue)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] fix error in codeowners
3 participants