Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding link in Icons section #1825

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Adding link in Icons section #1825

merged 2 commits into from
Oct 6, 2023

Conversation

Prakhar-Shankar
Copy link
Contributor

Fixes Issue

Closes #1824

Changes proposed

Added a link in Icons section

Note to reviewers

Would love to add more contributions.

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 7:23pm

@github-actions github-actions bot added quick-fix Shouldn't take much time to finish goal: new-link Addition of new links related contributions labels Oct 5, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Prakhar-Shankar, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@CBID2
Copy link
Collaborator

CBID2 commented Oct 5, 2023

Hi @Prakhar-Shankar! :) Welcome to LinksHub! :) We don't accept spam pull requests, so I'm putting yours in draft mode so I can review your issue. In the future, please wait until your issue has been approved and assigned to you before you submit a pull request. Refer to our Contributing Guide to learn how to effectively contribute to the project. Happy Contributing! 😊

@CBID2 CBID2 closed this Oct 5, 2023
@CBID2 CBID2 reopened this Oct 5, 2023
@CBID2 CBID2 marked this pull request as ready for review October 5, 2023 19:04
database/frontend/icons.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Prakhar-Shankar! :) I pointed out a proofreading error in my inline comment. In the future, consider running your descriptions through Grammarly or spell check before making a pull request. Other than that, you're off to a great start! :)

@Prakhar-Shankar
Copy link
Contributor Author

Hi @Prakhar-Shankar! :) I pointed out a proofreading error in my inline comment. In the future, consider running your descriptions through Grammarly or spell check before making a pull request. Other than that, you're off to a great start! :)

Hi, thank you for the suggestion. I will take care of this in the future.

@rupali-codes
Copy link
Owner

Reference in ne

Its alright :)

@rupali-codes rupali-codes added priority: low Addition of new links/categories or doing any small task (e.g fixing typos) hacktoberfest hacktoberfest2023 hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest labels Oct 6, 2023
@rupali-codes rupali-codes merged commit 269bac6 into rupali-codes:main Oct 6, 2023
2 checks passed
@Prakhar-Shankar Prakhar-Shankar deleted the adding-link branch October 6, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-link Addition of new links related contributions hacktoberfest hacktoberfest2023 hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest priority: low Addition of new links/categories or doing any small task (e.g fixing typos) quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add] Adding a link in, category- frontend, sub-category - Icons
3 participants