-
-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] Cybersecurity modules #1814
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Gobinath-B, for creating this pull request and contributing to LinksHub! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
Woah! Nicely done. Just one more thing, add a description of cybersecurity. And the PR is good to go. I will check the resources and then if these are the valid ones, we will merge it quickly. |
@Anmol-Baranwal got it, i will work on this! |
Hey @Gobinath-B. Can you post a screenshot of the card having a description of cybersecurity? I can’t tap on i icon on my tablet |
@Anmol-Baranwal @CBID2 I add a description for each subcategory of cyber security module and there is a bug #1837 in description card that mistakenly passes main category name instead of every sub category name. I resolved that bug too. @CBID2 here is the Screenshot: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Anmol-Baranwal removed conference from resources. did you check this bug #1837 ? I resolved in this PR. |
Yeah, I was about to make the issue in a day or two. Thanks for resolving it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Looks good to me.
@CBID2 can you please review the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @Gobinath-B
can you please add bug fixed label for this |
@Gobinath-B Following the PR template is a must. It includes special words like 'fixes' or 'resolves' that connect your issue to the PR, as explained in the official docs. If you don't link the issue correctly, even after the PR is merged, the issue might stay open, causing huge problems. I'm doing it for you this time. Please ensure it next time. Just a heads-up to help you link issue properly next time. Have a great day! |
How was this a bug? |
Oh! You was talking about another issue. Thanks for pointing out. Also, there is no bug fixed label😅 Wait, let me add it for you in the repo. |
Thank you so much @Anmol-Baranwal . Happy to contribute with you. |
fixes Issue
fixes #1785
fixes #1837
Changes proposed
. I added a new module
. Module Name: Cybersecurity
. Purpose: This module provides a central hub for curated cybersecurity resources, including articles, tools, and tutorials.
. Benefits: Access a one-stop source for enhancing your cybersecurity knowledge and skills.
. Add type for subcat in data.ts file.
. return the filtered items in UseDB.ts file
Screenshots