Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Cybersecurity modules #1814

Merged
merged 17 commits into from
Oct 6, 2023
Merged

[ADD] Cybersecurity modules #1814

merged 17 commits into from
Oct 6, 2023

Conversation

Gobinath-B
Copy link
Contributor

@Gobinath-B Gobinath-B commented Oct 5, 2023

fixes Issue

fixes #1785
fixes #1837

Changes proposed

. I added a new module
. Module Name: Cybersecurity
. Purpose: This module provides a central hub for curated cybersecurity resources, including articles, tools, and tutorials.
. Benefits: Access a one-stop source for enhancing your cybersecurity knowledge and skills.
. Add type for subcat in data.ts file.
. return the filtered items in UseDB.ts file

Screenshots

Screenshot (195)

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 9:56am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Gobinath-B, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@Anmol-Baranwal
Copy link
Collaborator

@Gobinath-B

Woah! Nicely done.

Just one more thing, add a description of cybersecurity. And the PR is good to go. I will check the resources and then if these are the valid ones, we will merge it quickly.

image

@Gobinath-B
Copy link
Contributor Author

@Gobinath-B

Woah! Nicely done.

Just one more thing, add a description of cybersecurity. And the PR is good to go. I will check the resources and then if these are the valid ones, we will merge it quickly.

image

@Anmol-Baranwal got it, i will work on this!

@CBID2
Copy link
Collaborator

CBID2 commented Oct 6, 2023

Hey @Gobinath-B. Can you post a screenshot of the card having a description of cybersecurity? I can’t tap on i icon on my tablet

@rupali-codes rupali-codes added hacktoberfest hacktoberfest2023 hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest labels Oct 6, 2023
@Gobinath-B
Copy link
Contributor Author

@Anmol-Baranwal @CBID2 I add a description for each subcategory of cyber security module and there is a bug #1837 in description card that mistakenly passes main category name instead of every sub category name. I resolved that bug too.

@CBID2 here is the Screenshot:

image

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these resources from respective subcategories:

image

image

A conference may not held up every year, and it is not suited for LinksHub.

@Gobinath-B
Copy link
Contributor Author

@Anmol-Baranwal removed conference from resources. did you check this bug #1837 ? I resolved in this PR.

@Anmol-Baranwal
Copy link
Collaborator

@Anmol-Baranwal removed conference from resources. did you check this bug #1837 ? I resolved in this PR.

Yeah, I was about to make the issue in a day or two.

Thanks for resolving it.

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@Gobinath-B
Copy link
Contributor Author

🚀 Looks good to me.

@CBID2 can you please review the code.

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @Gobinath-B

@CBID2 CBID2 merged commit aa1101d into rupali-codes:main Oct 6, 2023
6 checks passed
@CBID2 CBID2 added goal: new-link Addition of new links related contributions quick-fix Shouldn't take much time to finish priority: low Addition of new links/categories or doing any small task (e.g fixing typos) and removed hacktoberfest hacktoberfest2023 labels Oct 6, 2023
@Gobinath-B
Copy link
Contributor Author

can you please add bug fixed label for this

@Anmol-Baranwal
Copy link
Collaborator

@Gobinath-B
I just noticed.

Following the PR template is a must. It includes special words like 'fixes' or 'resolves' that connect your issue to the PR, as explained in the official docs.

If you don't link the issue correctly, even after the PR is merged, the issue might stay open, causing huge problems.

You can see here. Corrected.
image

I'm doing it for you this time. Please ensure it next time.

Just a heads-up to help you link issue properly next time. Have a great day!

@Anmol-Baranwal Anmol-Baranwal added the hacktoberfest hacktoberfest2023 label Oct 6, 2023
@Anmol-Baranwal
Copy link
Collaborator

can you please add bug fixed label for this

How was this a bug?

@Gobinath-B
Copy link
Contributor Author

#1837

@Anmol-Baranwal
Copy link
Collaborator

#1837

Oh! You was talking about another issue. Thanks for pointing out.

Also, there is no bug fixed label😅

Wait, let me add it for you in the repo.

@Anmol-Baranwal Anmol-Baranwal added the goal: bug-fixed For PRs resolving bugs label Oct 6, 2023
@Gobinath-B
Copy link
Contributor Author

Thank you so much @Anmol-Baranwal . Happy to contribute with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: bug-fixed For PRs resolving bugs goal: new-link Addition of new links related contributions hacktoberfest hacktoberfest2023 hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest priority: low Addition of new links/categories or doing any small task (e.g fixing typos) quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Sub category description describes main category name [ADD] Offensive security resourcses
4 participants