Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix1806 sidebar responsive #1809

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Fix1806 sidebar responsive #1809

merged 2 commits into from
Oct 5, 2023

Conversation

yashnirmal
Copy link
Contributor

Fixes Issue

Closes #1806

Changes proposed

Made the sidebar responsive by adding a new media-query

Screenshots

Screenshot 2023-10-05 at 12 04 08 PM

Note to reviewers

None

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 6:36am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, yashnirmal, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@github-actions github-actions bot added the bug Something isn't working label Oct 5, 2023
@CBID2 CBID2 added hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest priority: medium Modifying an existing feature labels Oct 5, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a Samsung so I'm going to keep my feedback general and say it's ok. @Anmol-Baranwal and @rupali-codes, what do you think?

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@CBID2
It works, no need to worry.

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @yashnirmal

@yashnirmal
Copy link
Contributor Author

thanks @CBID2

@CBID2 CBID2 merged commit 95073d7 into rupali-codes:main Oct 5, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest priority: medium Modifying an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Side navigation bar is not responsive for Samsung Galaxy fold
3 participants