Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: eva icons #1777

Merged
merged 4 commits into from
Oct 4, 2023
Merged

add: eva icons #1777

merged 4 commits into from
Oct 4, 2023

Conversation

akshayitzme
Copy link
Contributor

@akshayitzme akshayitzme commented Oct 3, 2023 •
edited
Loading

Screenshots

image

fixes #1792

@vercel
Copy link

vercel bot commented Oct 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 0:16am

github-actions[bot]
github-actions bot reviewed Oct 3, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, akshayitzme, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@CBID2 CBID2 closed this Oct 3, 2023
@CBID2
Copy link
Collaborator

CBID2 commented Oct 3, 2023 •
edited
Loading

Hi @akshayitzme! :) Welcome to LinksHub! :) Your PR has been closed because you have not raised an issue nor been assigned to it. Please read the Issue Requests section of our Contributing Guide to learn how to do this. After your raised issue is approved and assigned to you, your PR will be reopened.

@CBID2 CBID2 mentioned this pull request Oct 3, 2023
Closed
@akshayitzme
Copy link
Contributor Author

akshayitzme commented Oct 4, 2023 •
edited
Loading

fixes #1792

@CBID2 @Anmol-Baranwal please reopen this PR

@CBID2 CBID2 reopened this Oct 4, 2023
rupali-codes
rupali-codes previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Anmol-Baranwal
Anmol-Baranwal previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@Anmol-Baranwal Anmol-Baranwal dismissed stale reviews from rupali-codes and themself via 5baecc9 October 4, 2023 12:12
Anmol-Baranwal
Anmol-Baranwal reviewed Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry, I mistakenly did this when I was resolving the merge conflict.

database/frontend/icons.json Outdated Show resolved Hide resolved
database/frontend/icons.json Outdated Show resolved Hide resolved
@Anmol-Baranwal
Copy link
Collaborator

Done! 😅

@Anmol-Baranwal
Copy link
Collaborator

@CBID2
review and merge it.

CBID2
CBID2 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @akshayitzme! :) You're making great progress! :) Keep it up! :)

@CBID2
Copy link
Collaborator

CBID2 commented Oct 4, 2023 •
edited
Loading

@CBID2

review and merge it.

Lol, I need your review first @Anmol-Baranwal

Anmol-Baranwal
Anmol-Baranwal approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@Anmol-Baranwal Anmol-Baranwal added hacktoberfest hacktoberfest2023 hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest labels Oct 4, 2023
@CBID2 CBID2 merged commit e38517b into rupali-codes:main Oct 4, 2023
7 checks passed
@CBID2
Copy link
Collaborator

CBID2 commented Oct 4, 2023

Well done @akshayitzme! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@Anmol-Baranwal Anmol-Baranwal Anmol-Baranwal approved these changes

@CBID2 CBID2 CBID2 approved these changes

@rupali-codes rupali-codes rupali-codes left review comments

Assignees

@akshayitzme akshayitzme

Labels
hacktoberfest hacktoberfest2023 hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Add] Eva Icons
4 participants
@akshayitzme @CBID2 @Anmol-Baranwal @rupali-codes