Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - remove slight scroll behavior from categories page #1772

Merged

Conversation

ketansaresa
Copy link
Contributor

@ketansaresa ketansaresa commented Oct 3, 2023

##Fixes Issue

closes #1736

Changes proposed

  • Removed class py-2 from footer which was causing the issue.

Screenshots

Screenshot 2023-10-03 at 5 19 30 PM

##Note to reviewers
Please check it @Anmol-Baranwal @rupali-codes

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 0:15am

@github-actions github-actions bot added the bug Something isn't working label Oct 3, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, ketansaresa, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@Anmol-Baranwal
Copy link
Collaborator

@ketansaresa
Please stick to the PR template, there are specific keywords for linking the issue to the PR like fixes or closes which you can read at official docs.

Here it is not linked.
image

This will most likely keep the issue open even if the PR is merged, so just keep in mind for future purpose.

I'm doing it for you this time.

@Anmol-Baranwal Anmol-Baranwal changed the title Fixed - scroll issue on categories screen - 1736 Fix - remove slight scroll behavior from categories page Oct 3, 2023
@Anmol-Baranwal Anmol-Baranwal added the hacktoberfest hacktoberfest2023 label Oct 3, 2023
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@CBID2 Please review this.

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @ketansaresa! :)

@CBID2 CBID2 merged commit 22405a1 into rupali-codes:main Oct 3, 2023
11 checks passed
@CBID2
Copy link
Collaborator

CBID2 commented Oct 3, 2023

Thanks for contributing @ketansaresa! 😊 It was wonderful working with you! 😄 If you want to stay updated on LinksHub, join our Discord community! :) We'd love to have you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest hacktoberfest2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] screen displaying categories shouldn't be scrollable
3 participants