Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Two class names with same css properties #2447

Closed
4 tasks done
Jay-Karia opened this issue Aug 3, 2024 · 5 comments
Closed
4 tasks done

[Refactor] Two class names with same css properties #2447

Jay-Karia opened this issue Aug 3, 2024 · 5 comments
Labels
goal: refactor Refactoring the codebase multiple issues priority: medium Modifying an existing feature

Comments

@Jay-Karia
Copy link
Contributor

File Name

components/Header/Header.tsx

Reason for Refactoring the Code

Here the class names: flexand hidden applies the same CSS Properties.

code

Checklist

  • I have checked the existing issues.
  • I have read the Contributing Guidelines.
  • The changes don't break the code and don't introduce new functionality.
  • I am willing to work on this issue (optional).
@Jay-Karia Jay-Karia added goal: refactor Refactoring the codebase priority: medium Modifying an existing feature labels Aug 3, 2024
Copy link

github-actions bot commented Aug 3, 2024

Hello Jay-Karia!
Thank you for raising this issue! 😊 Your contribution is valuable to us! 😊

Please make sure to follow our Contributing Guidelines. 💪🏻

Please only work on an issue if you're assigned; otherwise, the PR will be automatically closed.
Our review team will carefully assess the issue and reach out to you soon! 😇
We appreciate your patience!

Copy link

github-actions bot commented Aug 3, 2024

#2444, #2443, #2442, #2439, #2438, #2436, #2435, #2434, #2428, #2427 is already opened by you
As per contributing guidelines, you can only work on 1 issue at a time.

@Jay-Karia
Copy link
Contributor Author

I can contribute

@rupali-codes
Copy link
Owner

Its not redundant, its for mobile view to hide the top nav-links and show them on tablets/desk view.

Copy link

github-actions bot commented Aug 7, 2024

Thank you for contributing to LinksHub! Please take a moment to rate this repo's DX on EddieHub's RepoRater and give it a star ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: refactor Refactoring the codebase multiple issues priority: medium Modifying an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants