Factor out kontrol module from kevm-pyk codebase
#1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothtamas28
approved these changes
Aug 10, 2023
anvacaru
pushed a commit
that referenced
this pull request
Aug 17, 2023
* kevm-pyk/src/kontrol: separate module for kontrol
* src/kevm_pyk: remove kontrol related functionality
* kevm-pyk/pyproject: expose kontrol binary
* kevm-pyk/src/kontrol/__init__: add stub init module
* kevm_pyk/src/tests: adjust for new kontrol module
* bin/kevm: route foundry-* commands through kontrol module
* Set Version: 1.0.244
* flake.nix: patch kontrol calls for nix builds too
* bin/kevm: add kontrol help to help message
* flake.nix: fix flake
* bin/kevm: correct syntax error
* bin/kevm, flake.nix: simplify calls to gst-to-kore/kontrol
* bin/kevm, flake.nix: simplify how kevm-pyk is invoked
* {kontrol,kevm_pyk}/__main__: adjust CLI name
* kevm-pyk/pyproject.toml: publish two separate packages
* package/docker/Dockerfile: try setting up PATH appropriately
* package/docker/Dockerfile: use newer version of poetry
* package/docker/Dockerfile: correct PATH
* Set Version: 1.0.250
* kevm-pyk/pyproject: publish packages correctly
* Set Version: 1.0.251
* Set Version: 1.0.252
* package/docker/Dockerfile: correct PATH
* Set Version: 1.0.254
* flake.nix: correct substitution for new file location
* Set Version: 1.0.261
* .github/test-pr: correct to normal runner for booster tests
---------
Co-authored-by: devops <[email protected]>
iFrostizz
pushed a commit
that referenced
this pull request
Aug 28, 2023
* kevm-pyk/src/kontrol: separate module for kontrol
* src/kevm_pyk: remove kontrol related functionality
* kevm-pyk/pyproject: expose kontrol binary
* kevm-pyk/src/kontrol/__init__: add stub init module
* kevm_pyk/src/tests: adjust for new kontrol module
* bin/kevm: route foundry-* commands through kontrol module
* Set Version: 1.0.244
* flake.nix: patch kontrol calls for nix builds too
* bin/kevm: add kontrol help to help message
* flake.nix: fix flake
* bin/kevm: correct syntax error
* bin/kevm, flake.nix: simplify calls to gst-to-kore/kontrol
* bin/kevm, flake.nix: simplify how kevm-pyk is invoked
* {kontrol,kevm_pyk}/__main__: adjust CLI name
* kevm-pyk/pyproject.toml: publish two separate packages
* package/docker/Dockerfile: try setting up PATH appropriately
* package/docker/Dockerfile: use newer version of poetry
* package/docker/Dockerfile: correct PATH
* Set Version: 1.0.250
* kevm-pyk/pyproject: publish packages correctly
* Set Version: 1.0.251
* Set Version: 1.0.252
* package/docker/Dockerfile: correct PATH
* Set Version: 1.0.254
* flake.nix: correct substitution for new file location
* Set Version: 1.0.261
* .github/test-pr: correct to normal runner for booster tests
---------
Co-authored-by: devops <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: runtimeverification/kontrol#4
The idea here is to factor out the
kontrolcodebase (now responsible forkevm foundry-*commands and also managingsolccompiled artifacts) into its own codebase.In particular:
solc_to_k.pyandfoundry.pyare factored out intokontrol.*module.kontrol.__main__.pyis added with all thesolcrelated functionality andfoundryrelated functionality.pyproject.tomlis modified to know about thekontrolbinary.bin/kevmis modified to call intokontrolbinary on calls tokevm solc*orkevm foundry-*.normalrunner.