Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing lytics user_id and anonymousId mapping #3745

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

shrouti1507
Copy link
Contributor

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-2669

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@shrouti1507 shrouti1507 marked this pull request as draft September 19, 2024 14:27
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (4c0c681) to head (4fd0797).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3745      +/-   ##
===========================================
+ Coverage    88.89%   88.94%   +0.04%     
===========================================
  Files          600      599       -1     
  Lines        32658    32574      -84     
  Branches      7757     7743      -14     
===========================================
- Hits         29032    28972      -60     
- Misses        3318     3325       +7     
+ Partials       308      277      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shrouti1507 shrouti1507 marked this pull request as ready for review September 23, 2024 15:21
@krishna2020 krishna2020 merged commit 45b1067 into develop Sep 30, 2024
19 checks passed
@krishna2020 krishna2020 deleted the lytics.event-stream-fix branch September 30, 2024 07:32
Copy link

sonarcloud bot commented Sep 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants