chore: one (*sql.DB) pool for all jobsdb #5170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5170 +/- ##
==========================================
- Coverage 72.91% 72.90% -0.02%
==========================================
Files 439 439
Lines 51138 51194 +56
==========================================
+ Hits 37287 37321 +34
- Misses 11390 11409 +19
- Partials 2461 2464 +3 ☔ View full report in Codecov by Sentry. |
lvrach
reviewed
Oct 7, 2024
| connStr := GetConnectionString(conf, componentName) | ||
| db, err := sql.Open("postgres", connStr) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("Error opening connection to database: %w", err) |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("Error opening connection to database: %w", err) | |
| return nil, fmt.Errorf("opening connection to database: %w", err) |
| @@ -35,6 +40,74 @@ func GetConnectionString(c *config.Config, componentName string) string { | |||
| ) | |||
| } | |||
|
|
|||
| func GetDatabaseConnectionPool( | |||
There was a problem hiding this comment.
Suggested change
| func GetDatabaseConnectionPool( | |
| func NewDatabaseConnectionPool( |
| } | ||
| if err := stat.RegisterCollector( | ||
| collectors.NewDatabaseSQLStats( | ||
| "jobsdb", |
There was a problem hiding this comment.
Suggested change
| "jobsdb", | |
| componentName, |
Comment on lines
+65
to
+67
| /* | ||
| TODO: find out a reasonably good value for below pool configurations | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /* | |
| TODO: find out a reasonably good value for below pool configurations | |
| */ |
| TODO: find out a reasonably good value for below pool configurations | ||
| */ | ||
|
|
||
| maxConnsVar := conf.GetReloadableIntVar(40, 1, "JobsDB.maxOpenConnections") |
There was a problem hiding this comment.
I would avoid using JobsDB, as it is an overloaded term.
Suggested change
| maxConnsVar := conf.GetReloadableIntVar(40, 1, "JobsDB.maxOpenConnections") | |
| maxConnsVar := conf.GetReloadableIntVar(40, 1, "db.pool.maxOpenConnections") |
Or even
Suggested change
| maxConnsVar := conf.GetReloadableIntVar(40, 1, "JobsDB.maxOpenConnections") | |
| maxConnsVar := conf.GetReloadableIntVar(40, 1, "db.pool.maxOpenConnections", "db."+componentName+".pool.maxOpenConnections") |
Comment on lines
+146
to
+147
| // Not deferring close here | ||
| // defer dbPool.Close() |
There was a problem hiding this comment.
What the reason for not closing here? Shall we inject dbPool to embeddedAppHandler. So we always use on connection pool
| @@ -139,13 +139,21 @@ func (a *embeddedApp) StartRudderCore(ctx context.Context, options *app.Options) | |||
| FeaturesRetryMaxAttempts: 10, | |||
| }) | |||
|
|
|||
| dbPool, err := misc.GetDatabaseConnectionPool(ctx, config, statsFactory, "jobsdb") | |||
There was a problem hiding this comment.
Suggested change
| dbPool, err := misc.GetDatabaseConnectionPool(ctx, config, statsFactory, "jobsdb") | |
| dbPool, err := misc.GetDatabaseConnectionPool(ctx, config, statsFactory, "embedded-app") |
I would avoid using jobsdb for anything else other than jobsdb component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One connection pool for all jobsdb.
In future, use the same pool across other areas(reporting, backend-config cache, drain-config etc. with appropriate increase in pool configurations)
Using given config(all of these are hot-reloadable):
maxOpenConnections: 40maxIdleConnections: 5maxIdleConnIdleTime: 15 MinutesmaxConnLifetime: 0Linear Ticket
Resolves PIPE-1602
Security